Hotfix: adjusting windows on integration tests to be full time range#462
Merged
cmcginley-splunk merged 2 commits intomainfrom Jan 14, 2026
Merged
Hotfix: adjusting windows on integration tests to be full time range#462cmcginley-splunk merged 2 commits intomainfrom
cmcginley-splunk merged 2 commits intomainfrom
Conversation
Contributor
cmcginley-splunk
commented
Jan 14, 2026
cmcginley-splunk
commented
- Hotfix to integration testing windows
- Previously hardcoded to a 5y lookback; now set to 0 (beginning of epoch)
patel-bhavin
previously approved these changes
Jan 14, 2026
pyth0n1c
previously approved these changes
Jan 14, 2026
Contributor
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
Approving, and providing some backing documentation. earliest_time appears to be either relative, which it was prior to this PR, or "absolute"
Here is the docs on the first this value populates:
https://docs.splunk.com/Documentation/Splunk/latest/Admin/savedsearchesconf#:~:text=dispatch.earliest_time%20%3D%20%3Ctime%2Dstr%3E
It does not explicitly list this as an epoch, but digging deeper into other docs and code examples reinforces the statement in the description of the PR that, when absolute, this is an epoch time.
cmcginley-splunk
dismissed stale reviews from pyth0n1c and patel-bhavin
via
52bfbd3
pyth0n1c
approved these changes
Jan 14, 2026
Contributor
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
Had an offline discussion about whether to include version bump in this PR or a separate PR. I agree it should be included here. Re-approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.